xtensa-build-all.sh: add ipc4 build support for tgl#5694
xtensa-build-all.sh: add ipc4 build support for tgl#5694lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
|
with this PR , users do not need to know what overlay configuration file should be adopted when building sof firmware IPC4 for tgl This is consistent with how we build for sof zephyr with xtensa-build-zephyr.py |
|
Can one of the admins verify this patch? |
|
@XiaoyunWu6666 this bash script is being deprecated in favor of the python script. I'm fine to merge this now (since it's needed), but lets also make sure we can do this in Python too (e.g. can you send PR to do the same for Python script). |
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Small fixes requested otherwise I'm fine with the approach.
@lgirdwood we don't have a python script for this, this script was never used by Windows developers, they always used CMake and ninja manually. You're confusing with the Python build.
There was a problem hiding this comment.
| cp "$IPC4_CONFIG_OVERLAY_FILE" override.config | |
| cat "${SOF_TOP}/src/arch/xtensa/configs/override/$IPC4_CONFIG_OVERLAY.config \ | |
| >> override.config |
Creating a new variable gives the wrong impression that it's going to be used somewhere else. Moreover the name is very similar to the other variable which is another potential source of confusion.
Keep this next to the other override.config options, having the menuconfig in the middle of the override.config does not seem to make sense.
There was a problem hiding this comment.
@marc-hb thanks for the comments! I've updated the commit.
It's more direct and intuitive now :) no risk of variable confusion
There was a problem hiding this comment.
Keep this (new lines) close to the (big block of) other override.config options
Please?
There was a problem hiding this comment.
I did not notice it because the menuconfig looks in the middle of override.config operations originally.
Now I moved the code of this commit （append something to override.config）after menuconfig change, while menuconfig change is still after the copy of the whole override.config file, is it OK ？
There was a problem hiding this comment.
I did not notice it because the menuconfig looks in the middle of override.config operations originally.
Yes and this is not ideal but the first bit of override.config code that is before menuconfig is quite different from the other ones if you look carefully.
marc-hb
requested review from
RanderWang,
bardliao,
fredoh9,
kv2019i and
plbossart
XiaoyunWu6666
force-pushed
the
ipc4_xtos
branch
from
ba98ee5 to
c87e40e
Compare
XiaoyunWu6666
requested review from
dbaluta,
lbetlej,
lgirdwood and
mmaka1
as code owners
ok, so Python build will only build a single target ? It seems like this "build all" should use the Python script in the future for each target ? |
|
@lgirdwood the |
There was a problem hiding this comment.
Code change looks good to me but commit c87e40ecbee43c adds two Zephyr git submodules by accident!? Maybe you did git add * or git commit -a something similar? Never ever use these commands. Or maybe it's your git client, try a better one.
XiaoyunWu6666
force-pushed
the
ipc4_xtos
branch
from
c87e40e to
0e362b1
Compare
|
@marc-hb sorry for adding spams to the commit by accident , I've updated it |
XiaoyunWu6666
force-pushed
the
ipc4_xtos
branch
from
0e362b1 to
013cdc4
Compare
Add ipc4 build support for tgl with IPC4_CONFIG_OVERLAY. If IPC_VERSION is chosen as IPC4, then overlay configuration file for different platforms will be used automatically without assigning the configuration file with options. Different configuration files will be used according to what platform is building firmware for. Signed-off-by: Xiaoyun Wu(Iris) <xiaoyun.wu@intel.com>
|
Not tested by internal CI so no need to block on it. |
5 participants
Add ipc4 build support for tgl with IPC4_CONFIG_OVERLAY.
If IPC_VERSION is chosen as IPC4, then overlay configuration file for different platforms will be used automatically without assigning the configuration file with options.
Different configuration files will be used according to what platformis building firmware for.
Signed-off-by: Xiaoyun Wu(Iris) xiaoyun.wu@intel.com